Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21445 )
Change subject: IMPALA-13102: Normalize invalid column stats from HMS ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21445/1/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/21445/1/tests/metadata/test_compute_stats.py@453 PS1, Line 453: > flake8: W504 line break after binary operator Done http://gerrit.cloudera.org:8080/#/c/21445/1/tests/metadata/test_compute_stats.py@454 PS1, Line 454: v > flake8: E131 continuation line unaligned for hanging indent Done http://gerrit.cloudera.org:8080/#/c/21445/1/tests/metadata/test_compute_stats.py@474 PS1, Line 474: client.update_table_column_sta > hmm, HMS could also reject these stats Added an assertion to check the result (bool). http://gerrit.cloudera.org:8080/#/c/21445/2/tests/metadata/test_compute_stats.py File tests/metadata/test_compute_stats.py: http://gerrit.cloudera.org:8080/#/c/21445/2/tests/metadata/test_compute_stats.py@454 PS2, Line 454: v > flake8: E131 continuation line unaligned for hanging indent Done -- To view, visit http://gerrit.cloudera.org:8080/21445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6216e3d6e73a529a9b3a8c0ea9d22727ab43f1a Gerrit-Change-Number: 21445 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 23 May 2024 00:59:34 +0000 Gerrit-HasComments: Yes
