Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20870 )
Change subject: IMPALA-12686: Build the toolchain with basic debug information (-g1) ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/20870/2/source/cmake/build.sh File source/cmake/build.sh: http://gerrit.cloudera.org:8080/#/c/20870/2/source/cmake/build.sh@27 PS2, Line 27: # Drop the -g1/-gz flags for CMake, as it is just a build utility and does not > Oddly enough, it didn't, but now that I'm looking at the new binaries, this I think it might be related to ccache. We use ccache 3.3.3, but 3.3.5 release notes mentions this: "Fixed a regression where the original order of debug options could be lost." https://ccache.dev/releasenotes.html#_ccache_3_3_5 So, I'm going to change this back to adding -g0 and file a separate ticket for upgrading ccache. -- To view, visit http://gerrit.cloudera.org:8080/20870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee2e264b281f83ebc226d9bf7d4e5a99a52f1fc6 Gerrit-Change-Number: 20870 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 31 May 2024 21:16:59 +0000 Gerrit-HasComments: Yes
