Hello Laszlo Gaal, Michael Smith,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21470
to look at the new patch set (#2).
Change subject: IMPALA-13072: Increase verbosity to print compilation commands
......................................................................
IMPALA-13072: Increase verbosity to print compilation commands
It is useful to be able to examine the compilation commands
to verify that custom flags are set (e.g. some components
use -fno-omit-frame-pointer, etc). Components that use
CMake often do not print the compilation command.
This modifies make invocations to pass in VERBOSE=1, which
prints the command being executed. This only passes in
VERBOSE=1 for make invocations that are doing compilation,
so it skips some locations that are only doing "make install"
after already compiling the project (or are header-only
projects).
Some projects don't respect VERBOSE=1. Boost has a special
-d+2 flag that turns on verbose output. Other projects like
CURL use configure's --disable-silent-rules flag to enable
verbose output.
The output is not too big and it gets redirected to a
file, so this does not make it configurable.
Testing:
- Ran a toolchain build and verified that the compilation
commands are in the output
Change-Id: I1a27bfe401c5def341b2e52f7d5e77d7f0e3a19e
---
M source/abseil-cpp/build.sh
M source/avro/build-cpp.sh
M source/avro/build.sh
M source/binutils/build.sh
M source/boost/build.sh
M source/breakpad/build.sh
M source/bzip2/build.sh
M source/calloncehack/build.sh
M source/cctz/build.sh
M source/cloudflarezlib/build.sh
M source/cmake/build.sh
M source/crcutil/build.sh
M source/curl/build.sh
M source/flatbuffers/build.sh
M source/gdb/build.sh
M source/gflags/build.sh
M source/glog/build.sh
M source/googlebenchmark/build.sh
M source/googletest/build.sh
M source/gperftools/build.sh
M source/gtest/build.sh
M source/kudu/build.sh
M source/libev/build.sh
M source/libpfm/build.sh
M source/libunwind/build.sh
M source/llvm/build-source-tarball.sh
M source/lz4/build.sh
M source/mold/build.sh
M source/openldap/build.sh
M source/protobuf/build.sh
M source/python/build.sh
M source/re2/build.sh
M source/snappy/build.sh
M source/thrift/build.sh
M source/tpc-ds/build.sh
M source/tpc-h/build.sh
M source/zlib/build.sh
M source/zstd/build.sh
38 files changed, 59 insertions(+), 53 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain
refs/changes/70/21470/2
--
To view, visit http://gerrit.cloudera.org:8080/21470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1a27bfe401c5def341b2e52f7d5e77d7f0e3a19e
Gerrit-Change-Number: 21470
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
