Hello Laszlo Gaal,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21473

to look at the new patch set (#2).

Change subject: IMPALA-13121: Switch to ccache 3.7.12
......................................................................

IMPALA-13121: Switch to ccache 3.7.12

The docker images currently build and use ccache 3.3.3.
Recently, we ran into a case where debuginfo was being
generated even though the cflags ended with -g0. The
ccache release history has this note for 3.3.5:
 - Fixed a regression where the original order of
   debug options could be lost.

This upgrades ccache to 3.7.12 to address this issue.

Ccache 3.7.12 is the last ccache release that builds
using autotools. Ccache 4 moves to build with CMake.
Adding a CMake dependency would be complicated at this
stage, because some of the older OSes don't provide a
new enough CMake in the package repositories. Since we
don't really need the new features of Ccache 4+, this
sticks with 3.7.12 for now.

This reenables the check_ccache_works() logic in
assert-dependencies-present.py.

Testing:
 - Built docker images and ran a toolchain build
 - The newer ccache resolves the unexpected debuginfo issue

Change-Id: I90d751445daa0dc298b634c1049d637a14afac40
---
M docker/all/assert-dependencies-present.py
M docker/all/postinstall.sh
2 files changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/native-toolchain 
refs/changes/73/21473/2
--
To view, visit http://gerrit.cloudera.org:8080/21473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I90d751445daa0dc298b634c1049d637a14afac40
Gerrit-Change-Number: 21473
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com>

Reply via email to