Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off ...................................................................... Patch Set 12: (5 comments) http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7473 PS10, Line 7473: > nit: loading Ack http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7480 PS10, Line 7480: etry insert again if there is table loading exception, since cache is updated : // using metastore api call > Should this call abortTransaction first for the failed update? Yeah, I intend to do it but somehow forgot it. Thanks for pointing out!. http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7482 PS10, Line 7482: TableLoadFail > Which operation can throw this exception? This is not required anymore. I planned to do an RPC call to HMS previously but we can get around with it. http://gerrit.cloudera.org:8080/#/c/21437/10/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7485 PS10, Line 7485: UnlockWriteLockIfErronouslyLocked(); > LOG the retry attempt before recursing? Ack. I have also logged the error at the beginning for table loading exception. http://gerrit.cloudera.org:8080/#/c/21437/10/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21437/10/tests/custom_cluster/test_events_custom_configs.py@1266 PS10, Line 1266: def test_ep_delay_metadata_reload_for_insert(self, unique_databas > Add comment about what this test do. Ack -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 12 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Jun 2024 20:17:17 +0000 Gerrit-HasComments: Yes
