Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21484 )
Change subject: IMPALA-12800: Add null slots cache ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/21484/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21484/8/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@663 PS8, Line 663: nullSlotsCache = : queryCtx.getClient_request().getQuery_options().use_null_slots_cache ? : CacheBuilder.newBuilder().concurrencyLevel(1).recordStats().build() : null; nit: I just remember, does Guava has reference-based eviction like Caffeine? https://github.com/ben-manes/caffeine/wiki/Eviction#reference-based For example, Caffeine.weakKeys() will let cache entries evicted if the key is not referenced anywhere anymore. -- To view, visit http://gerrit.cloudera.org:8080/21484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib63f5553284f21f775d2097b6c5d6bbb63699acd Gerrit-Change-Number: 21484 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Jun 2024 22:37:29 +0000 Gerrit-HasComments: Yes
