Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21493 )
Change subject: IMPALA-13131: Azure OpenAI API expects 'api-key' instead of 'Authorization' in the request header ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Thanks Abhishek. It looks good to me. http://gerrit.cloudera.org:8080/#/c/21493/4/be/src/exprs/ai-functions.inline.h File be/src/exprs/ai-functions.inline.h: http://gerrit.cloudera.org:8080/#/c/21493/4/be/src/exprs/ai-functions.inline.h@79 PS4, Line 79: Status status = getAuthorizationHeader<platform>(authHeader, ai_api_key_); : if (!status.ok()) return copyErrorMessage(ctx, status.msg().msg()); nit. can we use a macro to simplify error handling in this case? If not, the current approach is also good to me. #define RETURN_STRINGVAL_IF_ERROR(ctx, stmt) \ do { \ const ::impala::Status& _status = (stmt); \ if (UNLIKELY(!_status.ok())) \ return copyErrorMessage(ctx, _status.msg().msg()); \ } while (false) -- To view, visit http://gerrit.cloudera.org:8080/21493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9cc07940ce355d511bcf0ee615ff31042d13eb5 Gerrit-Change-Number: 21493 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 10 Jun 2024 16:05:36 +0000 Gerrit-HasComments: Yes
