Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 )
Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh. ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/21297/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21297/4//COMMIT_MSG@7 PS4, Line 7: . nit: remove period at the end http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh@176 PS4, Line 176: usage add ">&2 " ? http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh@189 PS4, Line 189: ${@} >> ${service_stdout} 2>> ${service_stderr} & Can we print a message about the redirection? E.g. stdout is redirected to /tmp/impalad.out stderr is redirected to /tmp/impalad.err http://gerrit.cloudera.org:8080/#/c/21297/4/package/bin/impala.sh@213 PS4, Line 213: usage add ">&2 " ? -- To view, visit http://gerrit.cloudera.org:8080/21297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib7743234952ba6b12694ecc68a920d59fea0d4ba Gerrit-Change-Number: 21297 Gerrit-PatchSet: 4 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Wed, 12 Jun 2024 08:30:13 +0000 Gerrit-HasComments: Yes
