Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21504 )
Change subject: IMPALA-13152: Avoid NaN, infinite, and negative ProcessingCost ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21504/2/fe/src/main/java/org/apache/impala/planner/DataSink.java File fe/src/main/java/org/apache/impala/planner/DataSink.java: http://gerrit.cloudera.org:8080/#/c/21504/2/fe/src/main/java/org/apache/impala/planner/DataSink.java@141 PS2, Line 141: "Processing cost of DataSink %s:%s is invalid! %s", fragment_.getId(), getLabel(), > nit: could improve this string construction using a format string with Prec Done http://gerrit.cloudera.org:8080/#/c/21504/2/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java File fe/src/main/java/org/apache/impala/planner/HashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/21504/2/fe/src/main/java/org/apache/impala/planner/HashJoinNode.java@342 PS2, Line 342: long outputCardinality = Math.max(0, getCardinality()); > Is there some reason we need cardinality_ to default to -1 rather than 0? PlanNode starts with unknown cardinality (-1) until stats are analyzed. Unknown is represented as -1, and some planner code handle unknown cardinality with best guess estimate like in some ScanNode subclasses when stats are unavailable. https://gerrit.cloudera.org/c/21504/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java#2256 -- To view, visit http://gerrit.cloudera.org:8080/21504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib49c7ae397dadcb2cb69fde1850d442d33cdf177 Gerrit-Change-Number: 21504 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Jun 2024 19:23:20 +0000 Gerrit-HasComments: Yes
