Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21452 )
Change subject: IMPALA-13088: (part 2) Parallelize final sorts in IcebergDeleteBuilder ...................................................................... Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21452/5/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/21452/5/be/src/exec/iceberg-delete-builder.cc@266 PS5, Line 266: int probes_waiting = NumProbesWaiting(); : : // Let's be conservative and only use 2/3 of available theads, because the scanner : // threads are not as CPU heavy as the sort threads. : r > Yeah, I think it's nice to extract it in a function. I didn't make 'probes_ It could still be made private within the block, but that would leave us with separate "protected" blocks, so yes, it's a tradeoff. http://gerrit.cloudera.org:8080/#/c/21452/5/be/src/exec/iceberg-delete-builder.cc@275 PS5, Line 275: for (auto& [path, intermediate_vec] : intermediate_delete_rows_) { > For formulas I prefer readability over the 4 spaces rule. Actually I do too. But it would also fit on one line, or do you want to emphasise that these are the two parameters? http://gerrit.cloudera.org:8080/#/c/21452/5/be/src/exec/iceberg-delete-builder.cc@296 PS5, Line 296: TURN_IF_ERROR(pool.Init()); : for (auto& [path, intermediate_vec] : intermediate_delete_rows_) { : BuildWorkItem work_item; : work_item.path = &path; > Thanks for the suggestions. Ok, I agree that keeping RAII is more important. -- To view, visit http://gerrit.cloudera.org:8080/21452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ca946a452d061238255e9b0e2c81a51cac68807 Gerrit-Change-Number: 21452 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 18 Jun 2024 09:24:11 +0000 Gerrit-HasComments: Yes
