Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21433 )
Change subject: IMPALA-13076 Add pstack and jstack to Impala Redhat docker images ...................................................................... IMPALA-13076 Add pstack and jstack to Impala Redhat docker images When the Impala docker images are deployed in production environments, it can be hard to add debugging tools at runtime. Two of the most useful diagnostic tools are jstack and pstack, which can be used to print Java and native stack traces. Install these tools into Redhat images which are the most commonly used in production. To install pstack we install gdb To install jstack we install a development jdk on top of the headless jdk. Extend the install_os_packages.sh script to add an argument to --install-debug-tools to set the level of diagnostic tools to install. The possible arguments are: none - install no extra tools basic - install pstack and jstack full - install more debugging tools. In a Centos 8.5 build, the size of a impalad_coord_exec image increased from 1.74GB to 1.85GB, as reported by ‘docker image list’. What other tools might be added? - Installing perf is tricky as in a container perf requires an installation specific to the underlying linux kernel image, which is hard to predict at build time. - Installing pprof is hard as installation seems to require compiling from sources. Clearly there are many options and we cannot install everything. TESTING Built release and debug docker images, and used jstack and pstack in a running container to print Impala's stacks. Change-Id: I25e6827b86564a9c0fc25678e4a194ee8e0be0e9 Reviewed-on: http://gerrit.cloudera.org:8080/21433 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Joe McDonnell <joemcdonn...@cloudera.com> --- M docker/CMakeLists.txt M docker/impala_base/Dockerfile M docker/impala_profile_tool/Dockerfile M docker/install_os_packages.sh 4 files changed, 44 insertions(+), 18 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I25e6827b86564a9c0fc25678e4a194ee8e0be0e9 Gerrit-Change-Number: 21433 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
