Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/21045/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21045/8//COMMIT_MSG@9 PS8, Line 9: The description of events-skipped metric is wrong. Some cases in Add partition : event ,the metric will also be increased, besides for some other cases like alter : partition the event is skipped and the log is printed but the events-skipped metric : is not increased. > Please format this to be 72 characters width. Add space after comma and rem Not done yet. http://gerrit.cloudera.org:8080/#/c/21045/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21045/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1811 PS8, Line 1811: > No, the function has bumped the skipped metric before the function returned Ack http://gerrit.cloudera.org:8080/#/c/21045/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21045/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2171 PS11, Line 2171: nit: keep using 4 spaces for indention http://gerrit.cloudera.org:8080/#/c/21045/8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/21045/8/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1995 PS8, Line 1995: // is IncompleteTable and addPartition event may also skip. > yes Could you explain when we will skip 3 events and when for 4? I think the original comment means the two AddPartition events will be skipped since the table is unloaded (i.e. is IncompleteTable). But it's unclear to me how the CreateDatabase event and two CreateTable events could be skipped. -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 11 Gerrit-Owner: Anonymous Coward <cclive1...@gmail.com> Gerrit-Reviewer: Anonymous Coward <cclive1...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Jun 2024 02:57:05 +0000 Gerrit-HasComments: Yes
