Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10165 )
Change subject: IMPALA-6941: load more text scanner compression plugins ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/10165/10/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java File fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java: http://gerrit.cloudera.org:8080/#/c/10165/10/fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java@216 PS10, Line 216: public boolean isFileCompressionTypeSupported(String fileName, > I took another look at this and realised we don't have any code coverage fo Doing this would also prevent a minor regression where loading, say, files with a ".lz4" suffix would work before this patch but not after this patch. -- To view, visit http://gerrit.cloudera.org:8080/10165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2a9c4a4a11bed81df706e9e834400bfedfe48e6 Gerrit-Change-Number: 10165 Gerrit-PatchSet: 10 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 10 May 2018 23:23:14 +0000 Gerrit-HasComments: Yes
