Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10370 )
Change subject: IMPALA-7010: don't run memory usage tests on non-HDFS ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10370/2/testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test File testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test: http://gerrit.cloudera.org:8080/#/c/10370/2/testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test@3 PS2, Line 3: # Check that hdfs writers respects mem_limit. maybe add comments to the test files saying the mem limit is tuned for 3 node hdfs cluster, to help prevent these from accidentally being added back to the full matrix. http://gerrit.cloudera.org:8080/#/c/10370/2/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/10370/2/tests/common/skip.py@130 PS2, Line 130: mem_usage_different = pytest.mark.skipif(IS_LOCAL, : reason="Memory limit too low when running single node") do we still need that? should all of these tests be "tuned_for_minicluster". And I don't understand the reason here anyway - local fs tests still use the minicluster (as do hdfs and isilon for that matter). They just use a different default filesystem. -- To view, visit http://gerrit.cloudera.org:8080/10370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9686195a29dde2d87b19ef8bb0e93e08f8bee662 Gerrit-Change-Number: 10370 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 11 May 2018 17:36:38 +0000 Gerrit-HasComments: Yes
