Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10327 )
Change subject: IMPALA-6907: Close stale connections to removed cluster members ...................................................................... IMPALA-6907: Close stale connections to removed cluster members Previously, ImpalaServer::MembershipCallback() is used by each Impala backend node to update cluster membership. It also removes stale connections to nodes which are no longer members of the cluster. However, the way it detects removed member is flawed as it relies on query_locations_ to determine whether stale connections may exist to the removed members. query_locations_ is a map of host name to a set of queries running on that host. A entry for a remote node only exists in query_locations_ if an Impalad node has acted as coordinator of a query with fragment instances scheduled to run on that remote node. This change fixes this problem by closing connections to remote hosts which are removed from the cluster regardless of whether it can be found in query_locations_. A new test is added to exercise this path by restarting Impalad backend nodes between queries. Also change impala_cluster.py to use bin/start-impala.sh to start Impala demon instead of directly forking and exec'ing Impalad. This is needed as start-impala.sh sets up the proper Java related environment variables. Change-Id: I41b7297cf665bf291b09b23524d19b1d10ab281d Reviewed-on: http://gerrit.cloudera.org:8080/10327 Reviewed-by: Michael Ho <k...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/service/impala-server.cc M tests/common/impala_cluster.py M tests/custom_cluster/test_restart_services.py 3 files changed, 56 insertions(+), 35 deletions(-) Approvals: Michael Ho: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/10327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I41b7297cf665bf291b09b23524d19b1d10ab281d Gerrit-Change-Number: 10327 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
