Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21699 )
Change subject: IMPALA-13313: Fix ExpireQueries deadlock ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21699/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21699/1//COMMIT_MSG@12 PS1, Line 12: acquiring the query_expiration_lock_ then a : session_state->lock > Can you mention where this call path is? ImpalaServer::ExpireQueries()? Answered in JIRA. http://gerrit.cloudera.org:8080/#/c/21699/1//COMMIT_MSG@18 PS1, Line 18: SetQueryInFlight held a session_state->lock and ExpireQueries held the : query_expiration_lock_ > This is the bad locking order, right? Answered in JIRA. -- To view, visit http://gerrit.cloudera.org:8080/21699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fce4103f6eeb7e9a4320ba1da817cab81071ba3 Gerrit-Change-Number: 21699 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 21 Aug 2024 00:08:15 +0000 Gerrit-HasComments: Yes
