Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21653 )
Change subject: IMPALA-12737: Refactor the Workload Management Initialization Process. ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/21653/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21653/8//COMMIT_MSG@19 PS8, Line 19: This patch splits the initialization code into its own file and adds > This portion of the commit message doesn't make sense since it foreshadows Done http://gerrit.cloudera.org:8080/#/c/21653/8//COMMIT_MSG@27 PS8, Line 27: schema will expand this list of allowed versions. > This portion of the commit message doesn't make sense since it foreshadows Done http://gerrit.cloudera.org:8080/#/c/21653/8/be/src/service/workload-management-flags.cc File be/src/service/workload-management-flags.cc: http://gerrit.cloudera.org:8080/#/c/21653/8/be/src/service/workload-management-flags.cc@178 PS8, Line 178: return !val.empty(); > The version is later parsed into a kudu::Version object. Rather than perfor Ack http://gerrit.cloudera.org:8080/#/c/21653/8/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21653/8/be/src/service/workload-management-init.cc@234 PS8, Line 234: _setupDb(internal_server_.get(), insert_query_opts); > Yes, this function and _setupTable both use "if not exists" on the DMLs the Ack http://gerrit.cloudera.org:8080/#/c/21653/8/be/src/service/workload-management-init.cc@268 PS8, Line 268: if (wm_schema_version.empty()) { > In this patch, 1.0.0 is the only valid version. The check in line 199 ensu I think my comment was incomplete. I'm not clear why the live table should have different error handling than the log table. There's no guarantee they'll have the same schema version property; an admin could have dropped and recreated the live table. -- To view, visit http://gerrit.cloudera.org:8080/21653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id645f94c8da73b91c13a23d7ac0ea026425f0f96 Gerrit-Change-Number: 21653 Gerrit-PatchSet: 9 Gerrit-Owner: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Aug 2024 22:05:08 +0000 Gerrit-HasComments: Yes
