Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21716 )
Change subject: IMPALA-13323: Remove redundant tests in test_join_queries.py ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21716/1/tests/query_test/test_join_queries.py File tests/query_test/test_join_queries.py: http://gerrit.cloudera.org:8080/#/c/21716/1/tests/query_test/test_join_queries.py@106 PS1, Line 106: add_exec_option_dimension(cls, 'mt_dop', mt_dop_dim(cls)) : : def test_single_node_nested_loop_joins(self, vector): : # Test the execution of nested-loops joins for join types that can only be : # executed in a single node (right [outer|semi|anti] and full outer joins). : self.run_test_case('QueryTest/single-node-nlj', vector) test_single_node_nested_loop_joins did not exercise mt_dop before, so mt_dop dimension can be drop in this TestSingleNodeJoins. test_single_node_nested_loop_joins_exhaustive, on the other hand, does exercise mt_dop. http://gerrit.cloudera.org:8080/#/c/21716/1/tests/query_test/test_join_queries.py@184 PS1, Line 184: TestSemiJoinQueries Rename to TestSemiJoins http://gerrit.cloudera.org:8080/#/c/21716/1/tests/query_test/test_join_queries.py@217 PS1, Line 217: TestSemiJoinQueriesExhaustive Rename to TestSemiJoinsExhaustive -- To view, visit http://gerrit.cloudera.org:8080/21716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76efa82dad59dbb9f58a36a4a2938b5f73a382f6 Gerrit-Change-Number: 21716 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Aug 2024 14:58:15 +0000 Gerrit-HasComments: Yes
