Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 34: (3 comments) http://gerrit.cloudera.org:8080/#/c/21142/37/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/37/be/src/service/workload-management-init.cc@85 PS37, Line 85: static void _appendCols(StringStreamPop& stream, : std::function<bool(const FieldDefinition& item)> shouldIncludeCol) { : bool match = false; > Says "Return true if..." but method is static void. Done http://gerrit.cloudera.org:8080/#/c/21142/37/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21142/37/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@4576 PS37, Line 4576: > Please mention which set this column is added to (select, where, join, etc) Done http://gerrit.cloudera.org:8080/#/c/21142/34/fe/src/test/java/org/apache/impala/planner/ColumnsTest.java File fe/src/test/java/org/apache/impala/planner/ColumnsTest.java: http://gerrit.cloudera.org:8080/#/c/21142/34/fe/src/test/java/org/apache/impala/planner/ColumnsTest.java@38 PS34, Line 38: public class ColumnsTest extends FrontendTestBase { > I'm asking because it looks like Path of complex type can ends with '.item' I'm following you now. I did a test, and the column sub items (such as db.type.struct_field.item1) are included on the list of columns. I fixed that issue and added a custom cluster test for it. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 34 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Aug 2024 19:03:16 +0000 Gerrit-HasComments: Yes
