Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 2: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21728/2/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/21728/2/be/src/transport/THttpServer.h@147 PS2, Line 147: std::function<bool(const std::string&)> oauth_token_auth_fn = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21728/2/be/src/transport/THttpServer.h@196 PS2, Line 196: // client on requests that do not contain a valid 'Authorization' of SAML SSO or JWT or line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 2 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 13 Sep 2024 21:13:44 +0000 Gerrit-HasComments: Yes
