Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21796 )
Change subject: IMPALA-13377: Excercise exec_option in test_recover_partitions.py ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21796/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21796/2//COMMIT_MSG@11 PS2, Line 11: never used anywhere. > nit: Should we want to mention that passing exec-option to query helps bett Passing query_option argument is not a requirement for execute_query_expect_success and other similar methods in impala_test_suite.py. It is fully in test writer discretion whether they want to craft one, modify one from test vector, or use vector.get_value('exec_option') as it is. ps 3 added documentation to remind about existence of vector.get_value('exec_option'). -- To view, visit http://gerrit.cloudera.org:8080/21796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e938dd8667937c996854032a1e13184c62d7b48 Gerrit-Change-Number: 21796 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Sep 2024 15:11:08 +0000 Gerrit-HasComments: Yes
