Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21565 )
Change subject: IMPALA-13197: Implement Analytic Exprs for Calcite ...................................................................... Patch Set 7: (3 comments) Needs another rebase. http://gerrit.cloudera.org:8080/#/c/21565/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/21565/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@116 PS7, Line 116: nit: gerrit highlights some extra whitespace in a few places that would be nice to clean up. http://gerrit.cloudera.org:8080/#/c/21565/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/21565/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@179 PS7, Line 179: private AnalyticExpr getAnalyticExpr(RexOver rexOver, PlannerContext ctx, ImpalaPlanRel inputRel, This line is too long. http://gerrit.cloudera.org:8080/#/c/21565/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@205 PS7, Line 205: if (CollectionUtils.isNotEmpty(rexWindow.orderKeys)) { We need this check because orderKeys could be null? -- To view, visit http://gerrit.cloudera.org:8080/21565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba5060546a7568ba0cd315f546daa78d89b1c3c5 Gerrit-Change-Number: 21565 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Sep 2024 22:30:52 +0000 Gerrit-HasComments: Yes
