Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10409 )
Change subject: IMPALA-7032: Disable codegen for CHAR type null literals ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Thanks for the quick review. I addressed your comment in PS2. Carrying Michael's +2. http://gerrit.cloudera.org:8080/#/c/10409/1/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test File testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test: http://gerrit.cloudera.org:8080/#/c/10409/1/testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test@48 PS1, Line 48: ---- > nit: extra ==== Done -- To view, visit http://gerrit.cloudera.org:8080/10409 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34033362263cf1292418f69c5ca1a3b84aed39a9 Gerrit-Change-Number: 10409 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 18:34:55 +0000 Gerrit-HasComments: Yes
