Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10412 )
Change subject: IMPALA-7033/IMPALA-7030: Backout suspected change leading to crash ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10412/1/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/10412/1/be/src/runtime/coordinator.h@45 PS1, Line 45: #include "util/runtime-profile-counters.h" : #include "util/spinlock.h" this was a conflict (due to my later change to make wait_lock_ a spinlock). http://gerrit.cloudera.org:8080/#/c/10412/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10412/1/be/src/runtime/coordinator.cc@a659 PS1, Line 659: : this was a conflict (due to later change to add this PrintId(). -- To view, visit http://gerrit.cloudera.org:8080/10412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc63006e6e04130b2873a6a9730e434c563327c5 Gerrit-Change-Number: 10412 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 18:51:37 +0000 Gerrit-HasComments: Yes