Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 )
Change subject: IMPALA-7025: ignore resources in some planner test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10410/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10410/2//COMMIT_MSG@13 PS2, Line 13: Instead of trying to tweak the test to avoid the issue, instead provide Why not ignore them everywhere instead of the tests that are specifically designed to check them? If the issue is related to data loading, then somebody might add a new planner test that breaks. It's not commented or documented anywhere why some tests ignore the mem estimates and others don't, so other people will not easily know whether to ignore or not when authoring new tests. -- To view, visit http://gerrit.cloudera.org:8080/10410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e3e416ec6242fbf22d9f566fdd1ce225cb16ac Gerrit-Change-Number: 10410 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 19:12:18 +0000 Gerrit-HasComments: Yes
