Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 )
Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10364/1/be/src/runtime/runtime-state.cc File be/src/runtime/runtime-state.cc: http://gerrit.cloudera.org:8080/#/c/10364/1/be/src/runtime/runtime-state.cc@210 PS1, Line 210: // (e.g. once per row) before the fragment aborts. See IMPALA-6997. > I wonder if we should explicitly check that the existing error is TErrorCod We usually record the first error that we hit. If the query status is not ok, then it is aborting. I think it is ok to skip this if we already hit a different error. http://gerrit.cloudera.org:8080/#/c/10364/1/be/src/runtime/runtime-state.cc@211 PS1, Line 211: if (!query_status_.ok()) return; > This probably works in practice but we don't guarantee that Status is threa Changed the code to hold the lock for this check. We can revisit this when we nail down the Status semantics. -- To view, visit http://gerrit.cloudera.org:8080/10364 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92b87f370a68a2f695ebbc2520a98dd143730701 Gerrit-Change-Number: 10364 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 19:51:54 +0000 Gerrit-HasComments: Yes
