Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 )
Change subject: IMPALA-6802 (part 3): Clean up authorization tests ...................................................................... Patch Set 2: (2 comments) Thanks for the cleanup, much more condensed! http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10358/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@859 PS2, Line 859: for (AuthzTest test : new AuthzTest[]{ > This redundancy cannot be removed since the objects are different. The objects are just passed as a string and the code appears to be identical otherwise, so can't we just loop over ["alltypes", "alltypes_view"] generating a new AuthzTest for each? http://gerrit.cloudera.org:8080/#/c/10358/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10358/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@522 PS3, Line 522: onColumn("functional", "alltypestiny", new String[]{"id", "bool_col", typo: trailing s -- To view, visit http://gerrit.cloudera.org:8080/10358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9681cc3c7094db33ab7c5caa69b99dd803b908b7 Gerrit-Change-Number: 10358 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 20:54:06 +0000 Gerrit-HasComments: Yes