Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22049 )
Change subject: IMPALA-10319: Support arbitrary encodings on Text/Sequence files ...................................................................... Patch Set 1: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/exec/text/hdfs-text-scanner.h File be/src/exec/text/hdfs-text-scanner.h: http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/exec/text/hdfs-text-scanner.h@183 PS1, Line 183: /// variables is brittle. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/exec/text/hdfs-text-scanner.cc File be/src/exec/text/hdfs-text-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/exec/text/hdfs-text-scanner.cc@100 PS1, Line 100: } line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/exec/text/hdfs-text-scanner.cc@569 PS1, Line 569: while (i < size && !((i + 1 < size && line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/exec/text/hdfs-text-scanner.cc@592 PS1, Line 592: return temp_decoding_pool_->mem_tracker()->MemLimitExceeded(nullptr, details, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/runtime/descriptors.cc File be/src/runtime/descriptors.cc: http://gerrit.cloudera.org:8080/#/c/22049/1/be/src/runtime/descriptors.cc@253 PS1, Line 253: encoding_value_ = tdesc.hdfsTable.__isset.encodingValue line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/1/tests/query_test/test_decoding.py File tests/query_test/test_decoding.py: http://gerrit.cloudera.org:8080/#/c/22049/1/tests/query_test/test_decoding.py@21 PS1, Line 21: from tests.util.filesystem_utils import get_fs_path, IS_HDFS, WAREHOUSE flake8: F401 'tests.util.filesystem_utils.IS_HDFS' imported but unused http://gerrit.cloudera.org:8080/#/c/22049/1/tests/query_test/test_decoding.py@21 PS1, Line 21: from tests.util.filesystem_utils import get_fs_path, IS_HDFS, WAREHOUSE flake8: F401 'tests.util.filesystem_utils.get_fs_path' imported but unused http://gerrit.cloudera.org:8080/#/c/22049/1/tests/query_test/test_decoding.py@24 PS1, Line 24: class TestDecoding(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/22049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I787cd01caa52a19d6645519a6cedabe0a5253a65 Gerrit-Change-Number: 22049 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 10 Nov 2024 18:18:58 +0000 Gerrit-HasComments: Yes
