Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/22062/1/be/src/exec/hdfs-columnar-scanner.cc File be/src/exec/hdfs-columnar-scanner.cc: http://gerrit.cloudera.org:8080/#/c/22062/1/be/src/exec/hdfs-columnar-scanner.cc@350 PS1, Line 350: Status HdfsColumnarScanner::GetCollectionMemory(CollectionValueBuilder* builder, MemPool** pool, line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22062/1/be/src/util/runtime-profile-counters.h File be/src/util/runtime-profile-counters.h: http://gerrit.cloudera.org:8080/#/c/22062/1/be/src/util/runtime-profile-counters.h@629 PS1, Line 629: /// avoided by “reclaiming” a page frame from the list of pages awaiting reallocation. line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 03:01:03 +0000 Gerrit-HasComments: Yes
