Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22062 )
Change subject: IMPALA-13487: Add profile counters for memory allocation ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/22062/11/be/src/runtime/mem-pool.cc File be/src/runtime/mem-pool.cc: http://gerrit.cloudera.org:8080/#/c/22062/11/be/src/runtime/mem-pool.cc@66 PS11, Line 66: DCHECK(chunks_.empty()) << "Must call FreeAll() or AcquireData() for this pool"; Just realized it's unexpected to free memory in the destructor. We can actually assume MemPoolCounters has the same life cycle of MemPool so it can be a field of MemPool. -- To view, visit http://gerrit.cloudera.org:8080/22062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I982315d96e6de20a3616f3bd2a2b4866d1ff4710 Gerrit-Change-Number: 22062 Gerrit-PatchSet: 11 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 25 Nov 2024 01:17:25 +0000 Gerrit-HasComments: Yes
