Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22210 )

Change subject: IMPALA-13603: Fix Flaky Live Queries Table Tests
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22210/6/tests/custom_cluster/test_query_live.py
File tests/custom_cluster/test_query_live.py:

http://gerrit.cloudera.org:8080/#/c/22210/6/tests/custom_cluster/test_query_live.py@a38
PS6, Line 38:
nit: it might be nice to update the implementation for wait_for_table_to_appear 
to do the same thing.


http://gerrit.cloudera.org:8080/#/c/22210/6/tests/custom_cluster/test_query_live.py@42
PS6, Line 42:           .service.read_debug_webpage("catalog?json")
I didn't know read_debug_webpage existed. Would be useful in some other tests.



--
To view, visit http://gerrit.cloudera.org:8080/22210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I767a2bd7b068ab3fdeddb7cb3c4b307844d2d279
Gerrit-Change-Number: 22210
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Mon, 16 Dec 2024 19:41:43 +0000
Gerrit-HasComments: Yes

Reply via email to