Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries in frontend ...................................................................... Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/21803/26/fe/src/main/java/org/apache/impala/service/Canceller.java File fe/src/main/java/org/apache/impala/service/Canceller.java: http://gerrit.cloudera.org:8080/#/c/21803/26/fe/src/main/java/org/apache/impala/service/Canceller.java@35 PS26, Line 35: * Global Java thread cancellation handler. Query-related operations register their thread I'm tempted to drop this and just use Thread.interrupt() / InterruptedException. We'll need to clearly document how that's handled, and add a bunch of exception propagation throughout the frontend, so it'll be a much larger change. We'll mostly want to switch to using lockInterruptibly and stop using the Uninterruptibles library. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 26 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2024 22:43:50 +0000 Gerrit-HasComments: Yes
