Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22297 )
Change subject: IMPALA-13641: Lazily init Parquet column read counters ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22297/2/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/22297/2/be/src/exec/hdfs-scan-node-base.cc@1258 PS2, Line 1258: auto uncompressed_bytes_counter = > counters_running_ seems to guard against this function being executed more I think it is still safe even if Instantiate() is called twice. It should be named InstantiateOrGet(), because if runtime_profile() already have counter with the same name, that existing counter will be returned instead. And https://github.com/apache/impala/blob/99529db6ad62ddc34cbfd924d7e41b1fce5b60a2/be/src/util/runtime-profile.h#L507-L518 Also, UpdateCounter() obtains lock. https://github.com/apache/impala/blob/99529db6ad62ddc34cbfd924d7e41b1fce5b60a2/be/src/util/runtime-profile.cc#L2495-L2496 -- To view, visit http://gerrit.cloudera.org:8080/22297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ba767b69b8c432f0eb954aa54f86876b329160c Gerrit-Change-Number: 22297 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sat, 04 Jan 2025 00:20:26 +0000 Gerrit-HasComments: Yes
