Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10413 )
Change subject: IMPALA-7019: Schedule EC as remote & disable failed tests ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/10413/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/10413/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@118 PS6, Line 118: FileBlock.createFbFileBlock(fbb, : loc.getOffset(), loc.getLength(), : (short) hostIndex.getIndex(REMOTE_NETWORK_ADDRESS)); > The reason is not strong: Though EC reads are remote, we might still don't ok, so you were worried that synthetic division into blocks could differ from how a file is chunked into blocks on hdfs. Assuming the block size provided by FileStatus never changes (L186), when would you see that the two different chunking schemes differ? -- To view, visit http://gerrit.cloudera.org:8080/10413 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138738d3e28e5daa1718c05c04cd9dd146c4ff84 Gerrit-Change-Number: 10413 Gerrit-PatchSet: 6 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 22 May 2018 18:27:05 +0000 Gerrit-HasComments: Yes
