Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22348 )
Change subject: Base changes to allow Calcite Parser to work ...................................................................... Patch Set 1: (15 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/CupParserFixture.java File fe/src/test/java/org/apache/impala/analysis/CupParserFixture.java: http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/CupParserFixture.java@228 PS1, Line 228: InsertStmt insertStmt = line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@282 PS1, Line 282: parserFixture_.TestInsertAndCtasHints("t", "t", hintStyle, "noshuffle", "noshuffle"); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@285 PS1, Line 285: parserFixture_.TestInsertAndCtasHints("t(a, b) partition(x, y)", "t partitioned by(x, y)", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@287 PS1, Line 287: parserFixture_.TestInsertAndCtasHints("t(a, b) partition(x, y)", "t partitioned by(x, y)", line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@402 PS1, Line 402: parserFixture_.TestJoinHints("select * from functional.alltypes a join /* comment */" + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@406 PS1, Line 406: parserFixture_.TestInsertStmtHints("insert %s into t(a, b) partition(x, y) %s select 1", line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@408 PS1, Line 408: parserFixture_.TestCtasHints("create /* comment */ table t partitioned by (x, y) as select 1", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@410 PS1, Line 410: parserFixture_.TestSelectListHints("select /* -- +straight_join */ * from functional.alltypes", line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@412 PS1, Line 412: parserFixture_.TestSelectListHints("select /* abcdef +straight_join */ * from functional.alltypes", line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@414 PS1, Line 414: parserFixture_.TestSelectListHints("select \n-- abcdef +straight_join\n * from functional.alltypes", line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@416 PS1, Line 416: parserFixture_.TestSelectListHints("select \n-- /*+straight_join\n * from functional.alltypes", line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@420 PS1, Line 420: parserFixture_.TestSelectListHints("select /*\n +straight_join */ * from functional.alltypes", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@422 PS1, Line 422: parserFixture_.TestSelectListHints("select /* +straight_join \n*/ * from functional.alltypes", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@424 PS1, Line 424: parserFixture_.TestSelectListHints("select /* +straight_\njoin */ * from functional.alltypes", line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/22348/1/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@436 PS1, Line 436: parserFixture_.TestSelectListHints("select /* +straight_join, ,, */ * from functional.alltypes", line too long (100 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6855336684dcdab7f4f5547126cae5906630f31 Gerrit-Change-Number: 22348 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 00:17:19 +0000 Gerrit-HasComments: Yes
