Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21931 )
Change subject: IMPALA-13205: Do not include Iceberg position fields for MERGE statements with INSERT merge clauses ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21931/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21931/2//COMMIT_MSG@10 PS2, Line 10: This patch makes the Iceberg position field inclusion conditional by : including them only if there are UPDATE or DELETE merge clauses that are : listed in a MERGE statement. Could you please explain in the commit message why this is needed? How did MERGE work before, was it incorrect or just unnecessary to include the position field? I saw that tests merge partitioned source to unpartitioned target tables. Does this have a relevance? If so, please explain here, if not, please cover the other cases. http://gerrit.cloudera.org:8080/#/c/21931/2/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge-insert-only.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge-insert-only.test: http://gerrit.cloudera.org:8080/#/c/21931/2/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge-insert-only.test@107 PS2, Line 107: unpartitioned Do you think it would make sense to add a test case with a partitioned target table as well? -- To view, visit http://gerrit.cloudera.org:8080/21931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib62c78dab557625fa86988559b3732591755106f Gerrit-Change-Number: 21931 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 15 Jan 2025 14:34:10 +0000 Gerrit-HasComments: Yes
