Hello Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10479 to look at the new patch set (#3). Change subject: IMPALA-6953: part 2: clean up DiskIoMgr ...................................................................... IMPALA-6953: part 2: clean up DiskIoMgr Follow-on changes. Made further mechanical changes that involved a lot of code motion: * Move code that manipulates RequestContext internal state to RequestContext * Don't use protected friend pattern that doesn't work as I thought * Remove some unused member variables and arguments * Move PerDiskState definition into .cc Change-Id: Ie82849652266b6660dd479689e5134273b172eb5 --- M be/src/exec/hdfs-orc-scanner.cc M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-parquet-scanner.h M be/src/exec/hdfs-scan-node-base.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/parquet-column-readers.cc M be/src/exec/scanner-context.cc M be/src/runtime/io/disk-io-mgr-stress.cc M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/io/disk-io-mgr.cc M be/src/runtime/io/disk-io-mgr.h M be/src/runtime/io/request-context.cc M be/src/runtime/io/request-context.h M be/src/runtime/io/request-ranges.h M be/src/runtime/io/scan-range.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h 17 files changed, 527 insertions(+), 565 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/10479/3 -- To view, visit http://gerrit.cloudera.org:8080/10479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie82849652266b6660dd479689e5134273b172eb5 Gerrit-Change-Number: 10479 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>