Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22134 )
Change subject: IMPALA-12992: Support for Hive JDBC Storage handler tables ...................................................................... Patch Set 6: (5 comments) > Patch Set 6: > > (9 comments) > > gerrit-auto-critic failed. You can reproduce it locally using command: > > python3 bin/jenkins/critique-gerrit-review.py --dryrun > > To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22134/6/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/22134/6/tests/custom_cluster/test_ext_data_sources.py@223 PS6, Line 223: v > flake8: U100 Unused argument 'vector' Done http://gerrit.cloudera.org:8080/#/c/22134/6/tests/custom_cluster/test_ext_data_sources.py@241 PS6, Line 241: > flake8: W293 blank line contains whitespace Done http://gerrit.cloudera.org:8080/#/c/22134/6/tests/custom_cluster/test_ext_data_sources.py@243 PS6, Line 243: > flake8: W293 blank line contains whitespace Done http://gerrit.cloudera.org:8080/#/c/22134/6/tests/custom_cluster/test_ext_data_sources.py@262 PS6, Line 262: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/22134/6/tests/custom_cluster/test_ext_data_sources.py@264 PS6, Line 264: ) > flake8: E501 line too long (91 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/22134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1674b93a02f43df8c1a449cdc54053cc80d9c458 Gerrit-Change-Number: 22134 Gerrit-PatchSet: 6 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 31 Jan 2025 09:58:53 +0000 Gerrit-HasComments: Yes
