Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10145 )
Change subject: IMPALA-5392: Added all stack frames to ThreadInfo summary. ...................................................................... Patch Set 10: > Hi Jim, > > Please ignore the last comment. I understand your concern. I > checked the current implementation, the same issue holds there as > well. HTML DOES NOT respect "newlines" and "tabs". > > Another point, as per my understanding, this API MUST NOT worry > about how it is rendered in HTML. The responsibility of rendering > it properly must lie with a frontend component. That is, we SHOULD > NOT add HTML line breaks in this API's return string. > > Please do let me know how should I address your concern. So it seems like we are embedding this text in HTML, but it's already PREformatted. What are your thoughts on how to handle that PREformatting? -- To view, visit http://gerrit.cloudera.org:8080/10145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80ab4aad03e0c1f01fecad6b87779531244c28b7 Gerrit-Change-Number: 10145 Gerrit-PatchSet: 10 Gerrit-Owner: Abhishek Sharma <abhishek.p...@gmail.com> Gerrit-Reviewer: Abhishek Sharma <abhishek.p...@gmail.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Charles Agnello <charles.w.agne...@gmail.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 24 May 2018 16:47:42 +0000 Gerrit-HasComments: No
