Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22474 )
Change subject: WIP IMPALA-11597: DROP STATS should unset table property impala.lastComputeStatsTime ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG@7 PS1, Line 7: WIP IMPALA-11597: DROP STATS should unset table property : impala.lastComputeStatsTime Title can be shorter. For example: IMPALA-11597: Unset impala.lastComputeStatsTime during DROP STATS http://gerrit.cloudera.org:8080/#/c/22474/1//COMMIT_MSG@11 PS1, Line 11: Does not affect the incremental variant: : 'DROP INCREMENTAL STATS t PARTITION (partition_spec)' Is there any test that validate this statement? http://gerrit.cloudera.org:8080/#/c/22474/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22474/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2824 PS1, Line 2824: boolean droppedLastCompute = : msTbl.getParameters().remove(HdfsTable.TBL_PROP_LAST_COMPUTE_STATS_TIME) != null; > You mean in terms of why this issue is needed? That's probably better to di What I'm asking is whether there is any other Catalog operation that depends on existence of 'impala.lastComputeStatsTime'. For example, what will happen in https://github.com/apache/impala/blob/c9e9f86c0536f0991f70613675bbcfbbccc6a324/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L2036C43-L2036C61 (IMPALA-11583)? Is it still work as intended? http://gerrit.cloudera.org:8080/#/c/22474/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/22474/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@266 PS1, Line 266: '','numRows ','2 Add validation that 'totalSize' is also gone. Maybe just copy RESULTS section of L248, but change it from VERIFY_IS_SUBSET to VERIFY_IS_NOT_IN -- To view, visit http://gerrit.cloudera.org:8080/22474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id743bc9779141df7a26a95a0ea201ef6fc6aeff9 Gerrit-Change-Number: 22474 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2025 23:27:26 +0000 Gerrit-HasComments: Yes
