Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22488 )
Change subject: IMPALA-13752: Remove option value quoting in __restore_query_options ...................................................................... Patch Set 1: Code-Review+1 (2 comments) > Patch Set 1: > > Build Successful > > https://jenkins.impala.io/job/gerrit-code-review-checks/18285/ : Initial code > review checks passed. Use gerrit-verify-dryrun-external or > gerrit-verify-dryrun to run full precommit tests. LGTM! Thanks Riza for the fix! http://gerrit.cloudera.org:8080/#/c/22488/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22488/1//COMMIT_MSG@15 PS1, Line 15: As consequece, nit: Please change it to "Consequently" or "As a consequence" . http://gerrit.cloudera.org:8080/#/c/22488/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22488/1/tests/common/impala_test_suite.py@536 PS1, Line 536: return nit: "returns" -- To view, visit http://gerrit.cloudera.org:8080/22488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I004ca021f64ffcc0c3d4cb2bb4aa550012b1be20 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Sun, 16 Feb 2025 13:22:57 +0000 Gerrit-HasComments: Yes
