Hello Jason Fehr, Peter Rozsa, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22486

to look at the new patch set (#3).

Change subject: IMPALA-13761: Fix test_coord_only_pool_exec_groups
......................................................................

IMPALA-13761: Fix test_coord_only_pool_exec_groups

IMPALA-13201 adds test_coord_only_pool_exec_groups. This test failed in
TestAdmissionControllerWithACService due to unaccounted AdmissionD as
the extra statestore subscriber. This patch fix the issue by using
expected_subscribers and expected_num_impalads argument for
CustomClusterTestSuite._start_impala_cluster() and relies on wait
mechanism inside it.

This patch also does some adjustments:
1. Tweak __run_assert_systables_query to not use
   execute_query_using_vector from IMPALA-13694.
2. Remove default_impala_client() call, first added by IMPALA-13668, and
   use self.client instead.
3. Fixed minor flake8 issue at test_coord_only_pool_happy_path.
These make it possible to backport IMPALA-13201 and IMPALA-13761
together to older release/maintenance branch.

Testing:
Run the test with this command:
impala-py.test --exploration=exhaustive \
  -k test_coord_only_pool custom_cluster/test_admission_controller.py

Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
---
M tests/custom_cluster/test_admission_controller.py
1 file changed, 17 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/22486/3
--
To view, visit http://gerrit.cloudera.org:8080/22486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I00b83e706aca3325890736133b2d1dcf735b19df
Gerrit-Change-Number: 22486
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>

Reply via email to