Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22488 )
Change subject: IMPALA-13752: Remove option value quoting in __restore_query_options ...................................................................... IMPALA-13752: Remove option value quoting in __restore_query_options Second run of test_parquet_late_materialization with codegen enabled failed because ENABLED_RUNTIME_FILTER_TYPES option failed to restored back to its default value, "BLOOM,MINMAX". The root cause is the new collect_default_query_options() function in impala_connection.py, added by IMPALA-13694. It will automatically wrap list values in double quote. Consequently, ImpalaTestSuite.__restore_query_options() does not need to wrap option value with another single quote. This patch also fix missing handling of optional query option without any default value. Testing: Run the test with this command: impala-py.test --exploration=exhaustive \ -k test_parquet_late_materialization \ query_test/test_parquet_late_materialization.py Change-Id: I004ca021f64ffcc0c3d4cb2bb4aa550012b1be20 Reviewed-on: http://gerrit.cloudera.org:8080/22488 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/common/impala_connection.py M tests/common/impala_test_suite.py 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I004ca021f64ffcc0c3d4cb2bb4aa550012b1be20 Gerrit-Change-Number: 22488 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]>
