Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22499 )

Change subject: WIP: IMPALA-13759: Fix Hive ACID INSERT OVERWRITE base detection
......................................................................


Patch Set 1:

(5 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22499/1/tests/query_test/test_acid.py
File tests/query_test/test_acid.py:

http://gerrit.cloudera.org:8080/#/c/22499/1/tests/query_test/test_acid.py@371
PS1, Line 371: d
flake8: E303 too many blank lines (2)


http://gerrit.cloudera.org:8080/#/c/22499/1/tests/query_test/test_acid.py@375
PS1, Line 375:
flake8: E222 multiple spaces after operator


http://gerrit.cloudera.org:8080/#/c/22499/1/tests/query_test/test_acid.py@379
PS1, Line 379: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/22499/1/tests/query_test/test_acid.py@384
PS1, Line 384:
flake8: E222 multiple spaces after operator


http://gerrit.cloudera.org:8080/#/c/22499/1/tests/query_test/test_acid.py@388
PS1, Line 388:
flake8: E222 multiple spaces after operator



--
To view, visit http://gerrit.cloudera.org:8080/22499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I838eaf4f41bae148e558f64288a1370c0908efa4
Gerrit-Change-Number: 22499
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 19 Feb 2025 12:35:45 +0000
Gerrit-HasComments: Yes

Reply via email to