Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22503 )
Change subject: IMPALA-13771: Fix heap-use-after-free in Cluster Membership Manager ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22503/2/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22503/2/be/src/scheduling/cluster-membership-mgr.cc@303 PS2, Line 303: > nit: extra whitespace It's confusing the way this is rendered in gerrit. There is not actually an extra whitespace: https://github.com/jasonmfehr/impala/blob/3461acc1e88e11b4ebf8e40ffb1e91c4153e3584/be/src/scheduling/cluster-membership-mgr.cc#L302-L311 http://gerrit.cloudera.org:8080/#/c/22503/2/be/src/scheduling/cluster-membership-mgr.cc@309 PS2, Line 309: new_backend_map->erase(item.key); > Ack Yes, it definitely matters! Michael's explanation is exactly what was happening. Added a comment. -- To view, visit http://gerrit.cloudera.org:8080/22503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fd2c9faa6daba9274f38238b952c377a07794e9 Gerrit-Change-Number: 22503 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 19 Feb 2025 22:33:25 +0000 Gerrit-HasComments: Yes
