Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22508 )
Change subject: IMPALA-13770: Updating Iceberg tables with UDFs crashes Impala ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/22508/2/be/src/exec/multi-table-sink.h File be/src/exec/multi-table-sink.h: http://gerrit.cloudera.org:8080/#/c/22508/2/be/src/exec/multi-table-sink.h@42 PS2, Line 42: virtual nit: virtual is redundant here http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test: http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@408 PS2, Line 408: Regression test for IMPALA-13770 Please add a test case for MERGE as well. http://gerrit.cloudera.org:8080/#/c/22508/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-update-basic.test@410 PS2, Line 410: create table update_with_udf(int_col INT) : stored by iceberg : tblproperties ('format-version'='2'); > I think it would be best to use a non-empty table. You could use an already I think we should use temporary tables for DML cases even if the DML statement doesn't modify the content of the table. The best approach here would be to create a temporary table and fill it with an already existing table. -- To view, visit http://gerrit.cloudera.org:8080/22508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id86638c8d6d86062c68cc9d708ec9c7b0a4e95eb Gerrit-Change-Number: 22508 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Feb 2025 12:19:23 +0000 Gerrit-HasComments: Yes
