Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 10: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22319/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java: http://gerrit.cloudera.org:8080/#/c/22319/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@64 PS10, Line 64: public ParsedStatement createParsedStatement(TQueryCtx queryCtx) throws ImpalaException { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22319/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java@90 PS10, Line 90: public AnalysisDriver createAnalysisDriver(AnalysisContext ctx) throws AnalysisException { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22319/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/22319/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@50 PS10, Line 50: protected static final Logger LOG = LoggerFactory.getLogger(CalciteSingleNodePlanner.class.getName()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/22319/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteSingleNodePlanner.java@55 PS10, Line 55: public CalciteSingleNodePlanner(PlannerContext ctx, CalciteAnalysisDriver analysisDriver) { line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 00:28:18 +0000 Gerrit-HasComments: Yes
