Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22468 )
Change subject: IMPALA-13729: Accept error messages not starting with prompt ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/22468/8/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: http://gerrit.cloudera.org:8080/#/c/22468/8/tests/common/test_result_verifier.py@a849 PS8, Line 849: > It seems before this patch, if no query id was given, the 'expected_msg' di You are right, Daniel. I missed that. I don't mind if expected_msg does not come right after the ERROR_REGEX if it specific enough that the assertion is not ambiguous. -- To view, visit http://gerrit.cloudera.org:8080/22468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac3e68bcc36776f7fd6cc9c838dd8da9c3ecf58b Gerrit-Change-Number: 22468 Gerrit-PatchSet: 9 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 21 Feb 2025 14:25:37 +0000 Gerrit-HasComments: Yes
