Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10490 )
Change subject: IMPALA-4970: Record identity of largest latency ExecQueryFInstances() ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10490/2/be/src/runtime/coordinator.cc@357 PS2, Line 357: int max_latency = 0; > I won't be able to do that as we need to iterate and find the max latency You're right. My bad. http://gerrit.cloudera.org:8080/#/c/10490/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/10490/3/be/src/runtime/coordinator.cc@365 PS3, Line 365: if (backend_state->rpc_latency() > max_latency) { Just one last comment: Could you add a comment above this line that says something like: "Find the backend that takes the most time to acknowledge the ExecQueryFInstances() RPC" -- To view, visit http://gerrit.cloudera.org:8080/10490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf9ce0d087c91c2e92ba5be08c96cc5364ae38dc Gerrit-Change-Number: 10490 Gerrit-PatchSet: 3 Gerrit-Owner: Rahul Shivu Mahadev <rahul.maha...@cloudera.com> Gerrit-Reviewer: Rahul Shivu Mahadev <rahul.maha...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 25 May 2018 16:44:58 +0000 Gerrit-HasComments: Yes
