Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22339 )
Change subject: IMPALA-13609: Store Iceberg snapshot id for COMPUTE STATS ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/22339/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22339/3//COMMIT_MSG@12 PS3, Line 12: A > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/22339/3//COMMIT_MSG@41 PS3, Line 41: 'impala.lastComputeStatsTime' table property from becoming too long, it : will only include information for 10 columns by default > Please explain what happens when there are more than 10 columns. Also, the How many columns do you think we should include? I think adding support for ranges would add considerable complexity. I'm not sure it's worth it. Using a wildcard for all columns may become inaccurate in case of schema modification, although that may be acceptable. Otherwise, about the question of what happens with remaining columns: right now, this information is not yet used by Impala for anything - that will be done in a follow-up change. For those columns, we could for example assume that the HMS stats are at least as old as the oldest snapshot present in the table property. http://gerrit.cloudera.org:8080/#/c/22339/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/22339/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@114 PS3, Line 114: c > nit: we usually put '=' after the name of the field, see above. Done -- To view, visit http://gerrit.cloudera.org:8080/22339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9998b84c4fd20d1cf5e97a34f3553832ec70ae7 Gerrit-Change-Number: 22339 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 13:28:47 +0000 Gerrit-HasComments: Yes
